Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use create_task instead of asyncio.run to put ws messages #575

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Use create_task instead of asyncio.run to put ws messages #575

merged 3 commits into from
Nov 20, 2023

Conversation

Pingdred
Copy link
Member

Description

Use create_task instead of asyncio.run to put ws messages

Related to issue #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Pingdred Pingdred marked this pull request as draft November 18, 2023 20:05
@Pingdred Pingdred marked this pull request as ready for review November 18, 2023 23:40
@pieroit pieroit merged commit a70716b into cheshire-cat-ai:develop Nov 20, 2023
1 check passed
@pieroit
Copy link
Member

pieroit commented Nov 20, 2023

Cool!!! Thanks (and thanks for letting me understand this async stuff)

@Pingdred Pingdred deleted the create_task branch December 30, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pingdred @pieroit